This project has retired. For details please refer to its Attic page.
cas-filemgr – FindBugs Bug Detector Report

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.0

Threshold is

Effort is min

Summary

Classes Bugs Errors Missing Classes
180 107 0 0

Files

Class Bugs
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog 15
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog 7
org.apache.oodt.cas.filemgr.catalog.LuceneCatalog 5
org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct 1
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog 10
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalogFactory 1
org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer 1
org.apache.oodt.cas.filemgr.catalog.solr.Parameters 1
org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory 1
org.apache.oodt.cas.filemgr.catalog.solr.SolrClient 1
org.apache.oodt.cas.filemgr.datatransfer.S3DataTransferer 1
org.apache.oodt.cas.filemgr.ingest.CachedIngester 1
org.apache.oodt.cas.filemgr.ingest.CmdLineIngester 1
org.apache.oodt.cas.filemgr.ingest.RmiCacheServer 1
org.apache.oodt.cas.filemgr.metadata.extractors.examples.TikaAutoDetectExtractor 1
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager 3
org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager 3
org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria 2
org.apache.oodt.cas.filemgr.structs.Product 1
org.apache.oodt.cas.filemgr.structs.Reference 2
org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator 2
org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent 1
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager 9
org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient 3
org.apache.oodt.cas.filemgr.tools.CASAnalyzer 4
org.apache.oodt.cas.filemgr.tools.CatalogSearch 2
org.apache.oodt.cas.filemgr.tools.DeleteProduct 1
org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool 1
org.apache.oodt.cas.filemgr.tools.RangeQueryTester 4
org.apache.oodt.cas.filemgr.tools.SolrIndexer 5
org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig 1
org.apache.oodt.cas.filemgr.util.SqlParser 2
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer 7
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer 4
org.apache.oodt.cas.filemgr.validation.XMLValidationLayer 1
org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner 1

org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.paginateQuery(Query, ProductType, int) STYLE REC_CATCH_EXCEPTION 2036 Medium
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addMetadataValue(Element, Product, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1361 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProduct(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 276 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.addProductReferences(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 602 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getNumProducts(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1489 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getProductByName(String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 737 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getProductsByProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 971 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getReducedMetadata(Product, List) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1140 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getResultListSize(Query, ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1809 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.getTopNProducts(int, ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1260 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.modifyProduct(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 391 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.removeMetadataValue(Element, Product, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1424 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.setProductTransferStatus(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 526 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.updateReferences(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 2181 High
org.apache.oodt.cas.filemgr.catalog.DataSourceCatalog.paginateQuery(Query, ProductType, int) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1992 Medium

org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog

Bug Category Details Line Priority
Call to java.util.Map$Entry<java.lang.String,java.lang.String>.equals(String) in org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.addMetadataValue(Map$Entry, Product, String) CORRECTNESS EC_UNRELATED_CLASS_AND_INTERFACE 443 High
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) STYLE REC_CATCH_EXCEPTION 370 Medium
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.addMetadataValue(Map$Entry, Product, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 440 High
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getMetadata(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 229 High
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getReducedMetadata(Product, List) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 364 High
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.getResultListSize(Query, ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 709 High
org.apache.oodt.cas.filemgr.catalog.LenientDataSourceCatalog.removeMetadataValue(String, Product, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 517 High

org.apache.oodt.cas.filemgr.catalog.LuceneCatalog

Bug Category Details Line Priority
Dead store to tdocks in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getMetadata(Product) STYLE DLS_DEAD_LOCAL_STORE 642 Medium
Possible null pointer dereference of startTerm in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getQuery(QueryCriteria) CORRECTNESS NP_NULL_ON_SOME_PATH 1488 Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.paginateQuery(Query, ProductType, int, ProductPage) STYLE REC_CATCH_EXCEPTION 1432 Medium
Private method org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getCompleteProductById(String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 374 Medium
Private method org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.toCompleteProduct(Document) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 1087 Medium

org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct

Bug Category Details Line Priority
Should org.apache.oodt.cas.filemgr.catalog.LuceneCatalog$CompleteProduct be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1510-1566 Medium

org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.commitQuery(StringBuffer, String) may fail to clean up java.sql.ResultSet EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 332 Medium
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createGranule(int, String) may fail to clean up java.sql.ResultSet EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 216 Medium
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createParameter(int, String) may fail to clean up java.sql.ResultSet EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 273 Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.addMetadata(Metadata, Product) STYLE REC_CATCH_EXCEPTION 195 Medium
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createGranule(int, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 216 High
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.createParameter(int, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 273 High
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getEndDateTime(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1120 High
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getNumProducts(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 409 High
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getProductByName(String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 496 High
org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalog.getStartDateTime(Product) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 1071 High

org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalogFactory

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive new org.apache.oodt.cas.filemgr.catalog.ScienceDataCatalogFactory() PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 64 High

org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer

Bug Category Details Line Priority
Call to method of static java.text.DateFormat in org.apache.oodt.cas.filemgr.catalog.solr.DefaultProductSerializer.serialize(Product, boolean) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 92 High

org.apache.oodt.cas.filemgr.catalog.solr.Parameters

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.catalog.solr.Parameters.SOLR_DATE_TIME_FORMATTER is a static field of type java.text.DateFormat, which isn't thread safe MT_CORRECTNESS STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE Not available High

org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.catalog.solr.SolrCatalogFactory.configure() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 66 Medium

org.apache.oodt.cas.filemgr.catalog.solr.SolrClient

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.oodt.cas.filemgr.catalog.solr.SolrClient.doHttp(HttpMethod): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 306 High

org.apache.oodt.cas.filemgr.datatransfer.S3DataTransferer

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.datatransfer.S3DataTransferer.stageFile(S3Object, Reference, File) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 119 High

org.apache.oodt.cas.filemgr.ingest.CachedIngester

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in new org.apache.oodt.cas.filemgr.ingest.CachedIngester(String, String, String) STYLE REC_CATCH_EXCEPTION 81 Medium

org.apache.oodt.cas.filemgr.ingest.CmdLineIngester

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.oodt.cas.filemgr.ingest.CmdLineIngester.readProdFilesFromStdin(): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 137 High

org.apache.oodt.cas.filemgr.ingest.RmiCacheServer

Bug Category Details Line Priority
Class org.apache.oodt.cas.filemgr.ingest.RmiCacheServer defines non-transient non-serializable instance field cache BAD_PRACTICE SE_BAD_FIELD Not available High

org.apache.oodt.cas.filemgr.metadata.extractors.examples.TikaAutoDetectExtractor

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.metadata.extractors.examples.TikaAutoDetectExtractor.getMetadataFromTika(Product) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 58 Medium

org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.addProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 98 High
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.getProductTypeByName(String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 400 High
org.apache.oodt.cas.filemgr.repository.DataSourceRepositoryManager.modifyProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 200 High

org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.addProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 78 High
org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.getProductTypeByName(String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 172 High
org.apache.oodt.cas.filemgr.repository.ScienceDataRepositoryManager.modifyProductType(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 273 High

org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria

Bug Category Details Line Priority
Write to static field org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.noiseWordHash from instance method new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 60 High
Write to static field org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria.noiseWordHash from instance method new org.apache.oodt.cas.filemgr.structs.FreeTextQueryCriteria(String, List) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 74 High

org.apache.oodt.cas.filemgr.structs.Product

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.oodt.cas.filemgr.structs.Product.parse(Document) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 355 High

org.apache.oodt.cas.filemgr.structs.Reference

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.structs.Reference.STREAM_REFERENCE_DELIMITER isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 64 High
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.structs.Reference.<static initializer for Reference>() STYLE REC_CATCH_EXCEPTION 73 Medium

org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator

Bug Category Details Line Priority
Comparison of String objects using == or != in org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator.compare(QueryResult, QueryResult) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 48 Medium
org.apache.oodt.cas.filemgr.structs.query.QueryResultComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 33-58 Medium

org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.structs.query.filter.TimeEvent.compareTo(TimeEvent) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 86 Medium

org.apache.oodt.cas.filemgr.system.XmlRpcFileManager

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.retrieveFile(String, int, int) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 937 High
Dead store to manager in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.main(String[]) STYLE DLS_DEAD_LOCAL_STORE 1204 Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.loadConfiguration() may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 1535 Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) may fail to clean up java.io.OutputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 977 Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.loadConfiguration() may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 1535 Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 977 Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.ingestProductCore(Map, Map, boolean) STYLE REC_CATCH_EXCEPTION 903 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.transferFile(String, byte[], int, int) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 974 Medium
org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.retrieveFile(String, int, int) ignores result of java.io.FileInputStream.skip(long) BAD_PRACTICE SR_NOT_CHECKED 916 Medium

org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient

Bug Category Details Line Priority
new org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient(URL, boolean) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 107 Medium
new org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient(URL, boolean) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 107 Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient.ingestProduct(Product, Metadata, boolean) STYLE REC_CATCH_EXCEPTION 1291 Medium

org.apache.oodt.cas.filemgr.tools.CASAnalyzer

Bug Category Details Line Priority
Dead store to result in org.apache.oodt.cas.filemgr.tools.CASAnalyzer.createComponents(String) STYLE DLS_DEAD_LOCAL_STORE 69 High
Unread field: org.apache.oodt.cas.filemgr.tools.CASAnalyzer.factory PERFORMANCE URF_UNREAD_FIELD 53 Medium
Unread field: org.apache.oodt.cas.filemgr.tools.CASAnalyzer.reader PERFORMANCE URF_UNREAD_FIELD 86 Medium
Unread field: org.apache.oodt.cas.filemgr.tools.CASAnalyzer.stopSet PERFORMANCE URF_UNREAD_FIELD 96 Medium

org.apache.oodt.cas.filemgr.tools.CatalogSearch

Bug Category Details Line Priority
Dead store to results in org.apache.oodt.cas.filemgr.tools.CatalogSearch.PostQuery(String, Query) STYLE DLS_DEAD_LOCAL_STORE 85 Medium
Found reliance on default encoding in org.apache.oodt.cas.filemgr.tools.CatalogSearch.main(String[]): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 336 High

org.apache.oodt.cas.filemgr.tools.DeleteProduct

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.oodt.cas.filemgr.tools.DeleteProduct.readProdIdsFromStdin(): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 212 High

org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in org.apache.oodt.cas.filemgr.tools.ProductTypeDocTool.doProductTypeDoc(String, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 94 Medium

org.apache.oodt.cas.filemgr.tools.RangeQueryTester

Bug Category Details Line Priority
Possible null pointer dereference of endFieldEndTerm in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.doRangeQuery(String) CORRECTNESS NP_NULL_ON_SOME_PATH 121 Medium
Possible null pointer dereference of startFieldEndTerm in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.doRangeQuery(String) CORRECTNESS NP_NULL_ON_SOME_PATH 103 Medium
Possible null pointer dereference of startFieldStartTerm in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.doRangeQuery(String) CORRECTNESS NP_NULL_ON_SOME_PATH 103 Medium
Possible null pointer dereference of endFieldStartTerm on branch that might be infeasible in org.apache.oodt.cas.filemgr.tools.RangeQueryTester.doRangeQuery(String) STYLE NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE 121 Medium

org.apache.oodt.cas.filemgr.tools.SolrIndexer

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.oodt.cas.filemgr.tools.SolrIndexer.readProductIdsFromStdin(): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 692 High
org.apache.oodt.cas.filemgr.tools.SolrIndexer.indexMetFile(File, boolean) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 214 Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.tools.SolrIndexer.deleteProductByName(String) STYLE REC_CATCH_EXCEPTION 512 Medium
Exception is caught when Exception is not thrown in org.apache.oodt.cas.filemgr.tools.SolrIndexer.indexProductByName(String, boolean) STYLE REC_CATCH_EXCEPTION 424 Medium
Call to method of static java.text.DateFormat in org.apache.oodt.cas.filemgr.tools.SolrIndexer.formatDate(SimpleDateFormat, String) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 568 Medium

org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig

Bug Category Details Line Priority
Should org.apache.oodt.cas.filemgr.tools.SolrIndexer$IndexerConfig be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 714-792 Medium

org.apache.oodt.cas.filemgr.util.SqlParser

Bug Category Details Line Priority
Switch statement found in org.apache.oodt.cas.filemgr.util.SqlParser.getInfixCriteriaString(QueryCriteria) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 180-201 Medium
Switch statement found in org.apache.oodt.cas.filemgr.util.SqlParser.getSqlStatementArgs(String) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 230-246 Medium

org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElement(Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 95 High
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addElementToProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 301 High
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.addParentToProductType(ProductType, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 428 High
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.getElements(ProductType) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 555 High
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.modifyElement(Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 177 High
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.removeElementFromProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 368 High
org.apache.oodt.cas.filemgr.validation.DataSourceValidationLayer.removeParentFromProductType(ProductType, String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 486 High

org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.addElement(Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 79 High
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.getElementByName(String) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 210 High
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.modifyElement(Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 361 High
org.apache.oodt.cas.filemgr.validation.ScienceDataValidationLayer.addElementToProductType(ProductType, Element) passes a nonconstant String to an execute method on an SQL statement SECURITY SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 118 Medium

org.apache.oodt.cas.filemgr.validation.XMLValidationLayer

Bug Category Details Line Priority
Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.oodt.cas.filemgr.validation.XMLValidationLayer.addElementToProductType(ProductType, Element) MT_CORRECTNESS AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION 142 Medium

org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner

Bug Category Details Line Priority
org.apache.oodt.cas.filemgr.versioning.AcquisitionDateVersioner.ACQ_DATE_FORMAT isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 59 High